Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove oauth interface auth #857

Merged
merged 1 commit into from
Dec 3, 2021
Merged

feat: remove oauth interface auth #857

merged 1 commit into from
Dec 3, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 3, 2021

Signed-off-by: Gaius [email protected]

Description

  • Remove oauth interface auth.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Dec 3, 2021
@gaius-qi gaius-qi self-assigned this Dec 3, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 3, 2021 02:39
@codecov-commenter
Copy link

Codecov Report

Merging #857 (a9f7a7d) into main (d063ef2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   41.34%   41.34%           
=======================================
  Files         103      103           
  Lines        8047     8047           
=======================================
  Hits         3327     3327           
- Misses       4306     4309    +3     
+ Partials      414      411    -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 53.82% <0.00%> (-1.23%) ⬇️
client/daemon/peer/peertask_file.go 52.02% <0.00%> (-0.34%) ⬇️
client/daemon/peer/peertask_base.go 46.66% <0.00%> (+0.60%) ⬆️
client/daemon/peer/peertask_stream_callback.go 64.07% <0.00%> (+1.94%) ⬆️

@gaius-qi gaius-qi merged commit 3f6e672 into main Dec 3, 2021
@gaius-qi gaius-qi deleted the feature/oauth branch December 3, 2021 03:06
gaius-qi added a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants