Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optmize dfget package upgrade support #804

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Nov 16, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner November 16, 2021 09:37
@jim3ma jim3ma force-pushed the feat/optmize-dfget-package branch from 94600a1 to 94ce694 Compare November 16, 2021 09:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #804 (3d943e8) into main (6f32500) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   40.64%   40.65%   +0.01%     
==========================================
  Files          95       95              
  Lines        7810     7812       +2     
==========================================
+ Hits         3174     3176       +2     
+ Misses       4233     4232       -1     
- Partials      403      404       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.65% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 46.06% <0.00%> (-0.61%) ⬇️
scheduler/supervisor/peer.go 50.74% <0.00%> (-0.39%) ⬇️
client/daemon/peer/peertask_stream.go 55.35% <0.00%> (+1.52%) ⬆️

@jim3ma jim3ma force-pushed the feat/optmize-dfget-package branch from 94ce694 to 3d943e8 Compare November 17, 2021 08:30
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 9d857ea into main Dec 10, 2021
@jim3ma jim3ma deleted the feat/optmize-dfget-package branch December 10, 2021 06:24
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
…dragonflyoss#805)

Revert "Refactor(deps)  update rust and golang versions in dockerfile (dragonflyoss#804)"

This reverts commit a70ecd8.

Signed-off-by: yxxhero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants