Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dump http content in client for debugging #770

Merged
merged 6 commits into from
Oct 29, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Oct 29, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner October 29, 2021 05:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #770 (2814c4b) into main (0d2ae1f) will decrease coverage by 0.06%.
The diff coverage is 29.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
- Coverage   37.96%   37.89%   -0.07%     
==========================================
  Files          90       90              
  Lines        6986     7035      +49     
==========================================
+ Hits         2652     2666      +14     
- Misses       3952     3983      +31     
- Partials      382      386       +4     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 37.89% <29.11%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/proxy/proxy.go 7.50% <0.00%> (-0.31%) ⬇️
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)
client/daemon/proxy/proxy_sni.go 0.00% <0.00%> (ø)
client/daemon/storage/local_storage.go 29.22% <0.00%> (-1.37%) ⬇️
client/daemon/transport/transport.go 61.60% <35.13%> (-10.69%) ⬇️
client/config/peerhost.go 36.00% <100.00%> (+0.51%) ⬆️
client/daemon/peer/peertask_base.go 35.01% <0.00%> (+1.25%) ⬆️

@jim3ma jim3ma force-pushed the feature/dump-http-content branch 2 times, most recently from 58951ff to 33c33bf Compare October 29, 2021 06:04
gaius-qi
gaius-qi previously approved these changes Oct 29, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

244372610
244372610 previously approved these changes Oct 29, 2021
244372610
244372610 previously approved these changes Oct 29, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 280e043 into main Oct 29, 2021
@gaius-qi gaius-qi deleted the feature/dump-http-content branch October 29, 2021 08:55
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: support dump http content in client for debugging

Signed-off-by: Jim Ma <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants