Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth2 #591

Merged
merged 9 commits into from
Sep 1, 2021
Merged

feat: oauth2 #591

merged 9 commits into from
Sep 1, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add oauth.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 31, 2021
@gaius-qi gaius-qi self-assigned this Aug 31, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 31, 2021 10:17
@gaius-qi gaius-qi changed the title feat: oauth feat: oauth2 Sep 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #591 (97a8b93) into main (fa22d7c) will decrease coverage by 0.09%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   38.76%   38.66%   -0.10%     
==========================================
  Files          87       87              
  Lines        6841     6856      +15     
==========================================
- Hits         2652     2651       -1     
- Misses       3814     3830      +16     
  Partials      375      375              
Flag Coverage Δ
e2etests ?
unittests 38.66% <10.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/permission/rbac/rbac.go 16.66% <10.00%> (-6.42%) ⬇️
client/daemon/peer/peertask_base.go 32.86% <0.00%> (-1.22%) ⬇️
client/daemon/peer/peertask_stream.go 56.94% <0.00%> (+1.69%) ⬆️

Signed-off-by: Gaius <[email protected]>
jim3ma
jim3ma previously approved these changes Sep 1, 2021
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi merged commit 2bce7b3 into main Sep 1, 2021
@gaius-qi gaius-qi deleted the feature/oauth branch September 1, 2021 11:08
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: add oauth2 signin

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants