Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework refactor #590

Merged
merged 8 commits into from
Aug 31, 2021
Merged

Framework refactor #590

merged 8 commits into from
Aug 31, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Aug 31, 2021

Description

refactor communication framework.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
@244372610 244372610 requested a review from a team as a code owner August 31, 2021 02:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #590 (81e1837) into main (1d038fa) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   39.00%   39.17%   +0.17%     
==========================================
  Files          86       86              
  Lines        6674     6701      +27     
==========================================
+ Hits         2603     2625      +22     
- Misses       3698     3704       +6     
+ Partials      373      372       -1     
Flag Coverage Δ
e2etests ?
unittests 39.17% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.07% <0.00%> (-0.61%) ⬇️
client/daemon/peer/peertask_file_callback.go 62.96% <0.00%> (ø)
client/daemon/peer/peertask_file.go 54.27% <0.00%> (+0.51%) ⬆️
manager/permission/rbac/rbac.go 23.07% <0.00%> (+1.80%) ⬆️
client/daemon/peer/peertask_stream.go 55.25% <0.00%> (+1.98%) ⬆️
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️
pkg/util/stringutils/string_utils.go 85.00% <0.00%> (+5.00%) ⬆️

Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
@244372610 244372610 merged commit 86c90ea into main Aug 31, 2021
@244372610 244372610 deleted the feature/framework-refactor branch August 31, 2021 12:36
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: optimize grpc

Signed-off-by: santong <[email protected]>

* feat: framework log

Signed-off-by: santong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants