Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload CDN client #566

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Reload CDN client #566

merged 4 commits into from
Aug 19, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Aug 19, 2021

Description

reload cdn client from dynamic config

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner August 19, 2021 11:34
scheduler/scheduler.go Outdated Show resolved Hide resolved
Signed-off-by: santong <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #566 (89eaa49) into main (f73fc50) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   39.27%   39.27%   -0.01%     
==========================================
  Files          86       86              
  Lines        6640     6641       +1     
==========================================
  Hits         2608     2608              
- Misses       3662     3663       +1     
  Partials      370      370              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 4.44% <0.00%> (-0.05%) ⬇️
scheduler/config/dynconfig.go 56.79% <ø> (ø)

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit fb54969 into main Aug 19, 2021
@244372610 244372610 deleted the feature/reloadCDNClient branch August 19, 2021 13:17
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* optimaze dynamic cdn hosts

Signed-off-by: santong <[email protected]>

* feat: set default cdn loadLimit

Signed-off-by: santong <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [jemalloc_pprof](https://github.com/polarsignals/rust-jemalloc-pprof) from 0.1.0 to 0.2.0.
- [Commits](https://github.com/polarsignals/rust-jemalloc-pprof/commits)

---
updated-dependencies:
- dependency-name: jemalloc_pprof
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants