Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize manager startup process #562

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: [email protected] [email protected]

Description

  • Optimize manager startup process.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi self-assigned this Aug 19, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 19, 2021 06:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #562 (d461765) into main (c5557c7) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   39.20%   39.23%   +0.03%     
==========================================
  Files          86       86              
  Lines        6640     6640              
==========================================
+ Hits         2603     2605       +2     
+ Misses       3668     3663       -5     
- Partials      369      372       +3     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.23% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream_callback.go 62.02% <0.00%> (-2.54%) ⬇️
client/daemon/peer/peertask_base.go 34.68% <0.00%> (ø)
client/daemon/peer/peertask_stream.go 55.74% <0.00%> (+1.39%) ⬆️

@gaius-qi gaius-qi force-pushed the feature/manager-start branch from a5549c4 to b70b946 Compare August 19, 2021 06:15
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/manager-start branch from b70b946 to e25ef35 Compare August 19, 2021 06:24
Signed-off-by: Gaius <[email protected]>
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scheduler/scheduler.go Outdated Show resolved Hide resolved
@gaius-qi gaius-qi merged commit dddf241 into main Aug 19, 2021
@gaius-qi gaius-qi deleted the feature/manager-start branch August 19, 2021 06:47
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: optimize manager startup process
Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants