Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler concurrent bug fix #513

Merged
merged 18 commits into from
Aug 2, 2021
Merged

scheduler concurrent bug fix #513

merged 18 commits into from
Aug 2, 2021

Conversation

244372610
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

244372610 added 10 commits July 27, 2021 23:14
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
Signed-off-by: santong <[email protected]>
@244372610 244372610 requested a review from a team as a code owner July 30, 2021 03:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #513 (6a01766) into main (f98401d) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   39.38%   39.43%   +0.04%     
==========================================
  Files          81       81              
  Lines        6299     6299              
==========================================
+ Hits         2481     2484       +3     
+ Misses       3456     3453       -3     
  Partials      362      362              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.43% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 32.94% <0.00%> (+0.70%) ⬆️

@244372610 244372610 changed the title [WIP]scheduler scheduler concurrent bug fix Aug 2, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 59a40f9 into main Aug 2, 2021
@jim3ma jim3ma deleted the feature/concurrentDeadLock branch August 2, 2021 11:42
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants