Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to set piece length for preheat #3848

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces the PieceLength parameter to various job management and scheduling functions, allowing for more granular control over piece lengths during file download tasks. This change affects multiple files and functions across the codebase, ensuring that the PieceLength parameter is properly handled and propagated through the system.

Key changes include:

Introduction of PieceLength Parameter:

Modification of TaskID Generation:

Job Management Updates:

Scheduler and Resource Updates:

Test and Utility Updates:

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 24, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 24, 2025
@gaius-qi gaius-qi self-assigned this Feb 24, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 24, 2025 10:09
@gaius-qi gaius-qi force-pushed the feature/piece-length branch from 28cbc51 to dde3f38 Compare February 24, 2025 11:31
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.12%. Comparing base (3d2eee6) to head (70b1ace).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/job/job.go 0.00% 5 Missing ⚠️
manager/job/task.go 0.00% 2 Missing ⚠️
manager/job/preheat.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   35.15%   35.12%   -0.04%     
==========================================
  Files         337      337              
  Lines       39282    39284       +2     
==========================================
- Hits        13811    13798      -13     
- Misses      24571    24582      +11     
- Partials      900      904       +4     
Flag Coverage Δ
unittests 35.12% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/idgen/task_id.go 80.85% <100.00%> (+1.78%) ⬆️
scheduler/resource/standard/task.go 78.48% <ø> (-0.36%) ⬇️
scheduler/scheduling/scheduling.go 63.34% <ø> (-0.06%) ⬇️
scheduler/service/service_v1.go 85.33% <ø> (ø)
scheduler/service/service_v2.go 46.49% <100.00%> (-0.05%) ⬇️
manager/job/preheat.go 46.09% <50.00%> (+0.02%) ⬆️
manager/job/task.go 69.69% <0.00%> (ø)
scheduler/job/job.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi force-pushed the feature/piece-length branch 3 times, most recently from 83f2bab to 2f1f730 Compare February 25, 2025 14:35
@gaius-qi gaius-qi requested a review from a team as a code owner February 25, 2025 14:35
@gaius-qi gaius-qi requested a review from bergwolf February 25, 2025 14:35
@gaius-qi gaius-qi force-pushed the feature/piece-length branch 2 times, most recently from e85bd2d to c617434 Compare February 26, 2025 04:36
@gaius-qi gaius-qi force-pushed the feature/piece-length branch from c617434 to 70b1ace Compare February 26, 2025 06:58
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 3232f7d into main Feb 26, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/piece-length branch February 26, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants