Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump api from v2.1.23 to v2.1.25 and add ttl for StatPersistentCacheTask #3830

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 12, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 12, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 12, 2025
@gaius-qi gaius-qi self-assigned this Feb 12, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 12, 2025 09:26
@gaius-qi gaius-qi changed the title feat: bump api from v2.1.23 to v2.1.25 and add ttl for StatPersistent… feat: bump api from v2.1.23 to v2.1.25 and add ttl for StatPersistentCacheTask Feb 12, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit dfa83b2 into main Feb 12, 2025
24 checks passed
@gaius-qi gaius-qi deleted the feature/ttl branch February 12, 2025 09:27
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.78%. Comparing base (d7a5eb8) to head (d7f69c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/service/service_v2.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3830   +/-   ##
=======================================
  Coverage   35.77%   35.78%           
=======================================
  Files         337      337           
  Lines       38986    38991    +5     
=======================================
+ Hits        13949    13953    +4     
- Misses      24116    24117    +1     
  Partials      921      921           
Flag Coverage Δ
unittests 35.78% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/service/service_v2.go 46.58% <0.00%> (-0.11%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants