Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove archives.format in goreleaser #3828

Merged
merged 2 commits into from
Feb 11, 2025
Merged

chore: remove archives.format in goreleaser #3828

merged 2 commits into from
Feb 11, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 11, 2025

Description

This pull request includes updates to image tags in the .github/workflows/compatibility-e2e-v2.yml file and a minor change in the .goreleaser.yml file. The most important changes are:

Workflow Updates:

  • Updated image tags for manager, scheduler, client, and seed-client modules to new versions in the .github/workflows/compatibility-e2e-v2.yml file.

Build Configuration:

  • Changed the format field to formats in the .goreleaser.yml file to support an array of formats.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 11, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 11, 2025
@gaius-qi gaius-qi self-assigned this Feb 11, 2025
@gaius-qi gaius-qi requested review from a team as code owners February 11, 2025 07:45
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.78%. Comparing base (84bfd66) to head (c3b9da9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #3828       +/-   ##
=========================================
+ Coverage      0   35.78%   +35.78%     
=========================================
  Files         0      337      +337     
  Lines         0    38986    +38986     
=========================================
+ Hits          0    13950    +13950     
- Misses        0    24115    +24115     
- Partials      0      921      +921     
Flag Coverage Δ
unittests 35.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 337 files with indirect coverage changes

@gaius-qi gaius-qi changed the title Feature/e2e chore: remove archives.format in goreleaser Feb 11, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 6506775 into main Feb 11, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/e2e branch February 11, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants