Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scheduler/scheduling): rename resource to standard #3815

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request focuses on updating the scheduler/scheduling/evaluator/evaluator_base_test.go file to standardize the usage of types from the standard package instead of the resource package. The key changes are as follows:

Standardization of types:

  • Changed the import from resource "d7y.io/dragonfly/v2/scheduler/resource/standard" to d7y.io/dragonfly/v2/scheduler/resource/standard for consistency.

  • Updated variable declarations to use types from the standard package instead of the resource package. This affects Host, CPU, Memory, Network, Disk, and Build types. [1] [2] [3] [4] [5] [6]

  • Modified the TestEvaluatorBase_EvaluateParents function to use standard.Peer and standard.Task types instead of resource.Peer and resource.Task. [1] [2] [3]

  • Updated the TestEvaluatorBase_evaluate function to use standard.Peer and standard.Task types instead of resource.Peer and resource.Task. [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 10, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Feb 10, 2025
@gaius-qi gaius-qi self-assigned this Feb 10, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner February 10, 2025 10:58
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.80%. Comparing base (a43f266) to head (31ef61a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3815      +/-   ##
==========================================
+ Coverage   35.77%   35.80%   +0.02%     
==========================================
  Files         337      337              
  Lines       38986    38986              
==========================================
+ Hits        13947    13957      +10     
+ Misses      24116    24109       -7     
+ Partials      923      920       -3     
Flag Coverage Δ
unittests 35.80% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@gaius-qi gaius-qi merged commit ff08ba2 into main Feb 10, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/evaluator branch February 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants