Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scheduler/resource): add host, peer and task uint tests #3790

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes several changes to the scheduler/resource/persistentcache package, adding new tests for the Host, Peer, and Task components, and updating dependencies in the go.mod file. The most important changes include the addition of comprehensive test cases for Host, Peer, and Task structs, as well as the inclusion of new dependencies for Redis and Redis mock.

Test Additions:

Dependency Updates:

  • go.mod: Added new dependencies for github.com/go-redis/redis and github.com/go-redis/redismock.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Jan 27, 2025
@gaius-qi gaius-qi added this to the v2.3.0 milestone Jan 27, 2025
@gaius-qi gaius-qi self-assigned this Jan 27, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner January 27, 2025 05:45
yxxhero
yxxhero previously approved these changes Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.28%. Comparing base (b2105b5) to head (c1608c7).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3790      +/-   ##
==========================================
+ Coverage   34.20%   34.28%   +0.07%     
==========================================
  Files         337      337              
  Lines       38982    38986       +4     
==========================================
+ Hits        13335    13366      +31     
+ Misses      24806    24775      -31     
- Partials      841      845       +4     
Flag Coverage Δ
unittests 34.28% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

yxxhero
yxxhero previously approved these changes Feb 10, 2025
@gaius-qi gaius-qi merged commit 2b75f86 into main Feb 10, 2025
27 checks passed
@gaius-qi gaius-qi deleted the feature/add-test branch February 10, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants