Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dfget param #373

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Feature/dfget param #373

merged 2 commits into from
Jun 28, 2021

Conversation

garfield009
Copy link
Collaborator

@garfield009 garfield009 commented Jun 25, 2021 •
edited
Loading

Description

adjust dfget grpc param

Related Issue

fix #372

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@garfield009
update image for arch
34b7cd7 
Signed-off-by: zuozheng.hzz <[email protected]>
@garfield009
feature: adjust dfget grpc param
dc28c4a 
Signed-off-by: zuozheng.hzz <[email protected]>
@garfield009 garfield009 requested a review from a team as a code owner June 25, 2021 11:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021 •
edited
Loading

Codecov Report

Merging #373 (dc28c4a) into main (0c8bee5) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   42.44%   42.51%   +0.07%     
==========================================
  Files          72       72              
  Lines        5614     5614              
==========================================
+ Hits         2383     2387       +4     
+ Misses       2885     2880       -5     
- Partials      346      347       +1
Flag Coverage Δ
unittests 42.51% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/service/manager.go 33.00% <100.00%> (ø)
client/daemon/peer/peertask_base.go 34.46% <0.00%> (+0.97%) ⬆️

@244372610 244372610 added this to the v0.1.0-beta milestone Jun 25, 2021
@garfield009 garfield009 requested a review from gaius-qi June 25, 2021 11:45
@gaius-qi gaius-qi merged commit e30ce07 into main Jun 28, 2021
@gaius-qi gaius-qi deleted the feature/dfget-param branch June 28, 2021 02:24
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@garfield009 @gaius-qi
Feature/dfget param (#373)
cab5ed6 
* update image for arch

Signed-off-by: zuozheng.hzz <[email protected]>

* feature: adjust dfget grpc param

Signed-off-by: zuozheng.hzz <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
feat: if registry is not set, create config_path for contianerd (drag…
831dbd3 
…onflyoss#373)

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@244372610 244372610 244372610 approved these changes

@jim3ma jim3ma Awaiting requested review from jim3ma

@ansinlee ansinlee Awaiting requested review from ansinlee

Assignees

@garfield009 garfield009

Labels
None yet
Projects
None yet
Milestone
v0.1.0-beta
Development

Successfully merging this pull request may close these issues.

adjust dfget param
4 participants
@garfield009 @codecov-commenter @gaius-qi @244372610