Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get task job and delete task job #3522

Merged
merged 1 commit into from
Sep 20, 2024
Merged

refactor: get task job and delete task job #3522

merged 1 commit into from
Sep 20, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 20, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 20, 2024
@gaius-qi gaius-qi self-assigned this Sep 20, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 20, 2024 07:01
@gaius-qi gaius-qi force-pushed the feature/task branch 2 times, most recently from 318cb64 to c951991 Compare September 20, 2024 07:07
@yxxhero
Copy link
Member

yxxhero commented Sep 20, 2024

pls fix ci.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 51.69%. Comparing base (fbb3ee3) to head (39d6723).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/job/task.go 0.00% 12 Missing ⚠️
manager/job/job.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3522      +/-   ##
==========================================
- Coverage   51.72%   51.69%   -0.04%     
==========================================
  Files         190      190              
  Lines       20422    20424       +2     
==========================================
- Hits        10564    10558       -6     
- Misses       9056     9061       +5     
- Partials      802      805       +3     
Flag Coverage Δ
unittests 51.69% <38.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/slices/slices.go 100.00% <100.00%> (ø)
manager/job/job.go 0.00% <0.00%> (ø)
manager/job/task.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 7bcbac9 into main Sep 20, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feature/task branch September 20, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants