Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/code spec #336

Merged
merged 70 commits into from
Jun 21, 2021
Merged

Feature/code spec #336

merged 70 commits into from
Jun 21, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Jun 13, 2021 •
edited
Loading

Description

Related Issue

fix #333

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

244372610 added 30 commits June 4, 2021 19:48
@244372610
feat: refactor cdn storage module & remove unused ctx
e26273d 
Signed-off-by: santong <[email protected]>
@244372610
feat: modify cdn config file
d543c20 
Signed-off-by: santong <[email protected]>
@244372610
parse cdn config file
754df73 
Signed-off-by: santong <[email protected]>
@244372610
fix load storage manager config error due to viper lower key & plugin…
b4ea91b 
… load order

Signed-off-by: santong <[email protected]>
@244372610
add unit tests
e55b793 
Signed-off-by: santong <[email protected]>
@244372610
move source package to pkg && mock sourceClient
da0288e 
Signed-off-by: santong <[email protected]>
@244372610
go linter
b3cfa78 
Signed-off-by: santong <[email protected]>
@244372610
peertask tests
a48c1bc 
Signed-off-by: santong <[email protected]>
@244372610
mock resourceClient of client
5c026f5 
Signed-off-by: santong <[email protected]>
@244372610
fix piece_manager_test unit test
b9e249e 
Signed-off-by: santong <[email protected]>
@244372610
unregister source client
4f1b9e9 
Signed-off-by: santong <[email protected]>
@244372610
add source client mgr
147d37a 
Signed-off-by: santong <[email protected]>
@244372610
feat: refactor cdn storage module & remove unused ctx
784c664 
Signed-off-by: santong <[email protected]>
@244372610
feat: modify cdn config file
1d39dd6 
Signed-off-by: santong <[email protected]>
@244372610
parse cdn config file
7da3670 
Signed-off-by: santong <[email protected]>
@244372610
fix load storage manager config error due to viper lower key & plugin…
f4c29dd 
… load order

Signed-off-by: santong <[email protected]>
@244372610
add unit tests
e77a74a 
Signed-off-by: santong <[email protected]>
@244372610
move source package to pkg && mock sourceClient
86c439a 
Signed-off-by: santong <[email protected]>
@244372610
go linter
99cf92f 
Signed-off-by: santong <[email protected]>
@244372610
peertask tests
f88aa0e 
Signed-off-by: santong <[email protected]>
@244372610
mock resourceClient of client
08d3e10 
Signed-off-by: santong <[email protected]>
@244372610
fix piece_manager_test unit test
323f460 
Signed-off-by: santong <[email protected]>
@244372610
unregister source client
cf3fea3 
Signed-off-by: santong <[email protected]>
@244372610
add source client mgr
e72a815 
Signed-off-by: santong <[email protected]>
@244372610
Merge branch 'feature/cdn-tests' of https://github.com/dragonflyoss/D…
fec847f 
…ragonfly2 into feature/cdn-tests
@244372610
translate chinese comments
c0c4014 
Signed-off-by: santong <[email protected]>
@244372610
feat: refactor cdn storage module & remove unused ctx
cf2bdf3 
Signed-off-by: santong <[email protected]>
@244372610
feat: modify cdn config file
f85d1ad 
Signed-off-by: santong <[email protected]>
@244372610
parse cdn config file
5dbfd21 
Signed-off-by: santong <[email protected]>
@244372610
add unit tests
adfb017 
Signed-off-by: santong <[email protected]>
@244372610 244372610 self-assigned this Jun 13, 2021
@244372610 244372610 requested a review from a team as a code owner June 13, 2021 11:30
@244372610 244372610 requested review from jim3ma, ansinlee and yangjun289519474 and removed request for a team June 13, 2021 11:30
@244372610 244372610 changed the title [WIN]Feature/code spec [WIP]Feature/code spec Jun 13, 2021
@244372610 244372610 changed the base branch from main-backup to main June 15, 2021 05:59
@244372610
merge main
5d327f3 
Signed-off-by: santong <[email protected]>
@244372610 244372610 changed the title [WIP]Feature/code spec Feature/code spec Jun 17, 2021
244372610 added 2 commits June 21, 2021 17:27
@244372610
merge main
2f91dc6 
Signed-off-by: santong <[email protected]>
@244372610
remove work pool code
fb29d58 
Signed-off-by: santong <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #336 (06580cd) into main (dcd3569) will decrease coverage by 0.06%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   39.92%   39.85%   -0.07%     
==========================================
  Files          62       61       -1     
  Lines        4989     4975      -14     
==========================================
- Hits         1992     1983       -9     
+ Misses       2740     2737       -3     
+ Partials      257      255       -2
Flag Coverage Δ
unittests 39.85% <95.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clientutil/keepalive.go 0.00% <ø> (ø)
client/daemon/peer/peertask_file_callback.go 62.96% <ø> (ø)
client/daemon/peer/peertask_manager.go 32.09% <ø> (ø)
client/daemon/peer/peertask_stream_callback.go 65.00% <ø> (+2.50%) ⬆️
client/daemon/peer/piece_downloader.go 68.29% <ø> (ø)
client/daemon/peer/piece_downloader_optimized.go 52.94% <ø> (ø)
client/daemon/peer/piece_manager.go 67.07% <ø> (ø)
client/daemon/peerhost.go 0.00% <ø> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <ø> (ø)
client/daemon/service/manager.go 33.00% <ø> (ø)
... and 13 more

jim3ma
jim3ma approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit 2101a4b into main Jun 21, 2021
@244372610 244372610 deleted the feature/codeSpec branch June 21, 2021 10:54
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@244372610 @gaius-qi
Feature/code spec (#336)
6cce5a9 
* Modify the code according to https://github.com/uber-go/guide/blob/master/style.md

Signed-off-by: santong <[email protected]>
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@ansinlee ansinlee ansinlee approved these changes

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474

Assignees

@244372610 244372610

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code style specification
5 participants
@244372610 @codecov-commenter @jim3ma @ansinlee @gaius-qi