Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cache peer to grpc api #3334

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat: add cache peer to grpc api #3334

merged 1 commit into from
Jun 18, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Jun 18, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Jun 18, 2024
@gaius-qi gaius-qi self-assigned this Jun 18, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner June 18, 2024 04:31
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.56%. Comparing base (dc0a171) to head (c130474).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3334      +/-   ##
==========================================
- Coverage   52.63%   52.56%   -0.07%     
==========================================
  Files         192      192              
  Lines       20456    20468      +12     
==========================================
- Hits        10766    10759       -7     
- Misses       8886     8905      +19     
  Partials      804      804              
Flag Coverage Δ
unittests 52.56% <30.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 82.49% <75.00%> (ø)
scheduler/rpcserver/scheduler_server_v2.go 2.94% <0.00%> (-0.64%) ⬇️

... and 5 files with indirect coverage changes

@gaius-qi gaius-qi merged commit a548876 into main Jun 18, 2024
28 checks passed
@gaius-qi gaius-qi deleted the feature/api branch June 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant