Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynconfig in schduler gets the cdn configuration from the directory #304

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 9, 2021

Signed-off-by: Gaius [email protected]

Description

  • Add getCDNFromDir in schduler's dynconfig.
  • Add Dynconfig.CDNDirPath in schduler's config.

Related Issue

#303

Motivation and Context

Scheduler does not need to rely on manager service.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested a review from a team as a code owner June 9, 2021 08:01
@gaius-qi gaius-qi self-assigned this Jun 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #304 (dee2c8a) into main (7084222) will increase coverage by 0.27%.
The diff coverage is 71.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   43.53%   43.81%   +0.27%     
==========================================
  Files          53       53              
  Lines        4176     4195      +19     
==========================================
+ Hits         1818     1838      +20     
+ Misses       2120     2119       -1     
  Partials      238      238              
Flag Coverage Δ
unittests 43.81% <71.05%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <ø> (ø)
internal/dynconfig/dynconfig.go 53.03% <61.53%> (ø)
scheduler/config/dynconfig.go 54.38% <76.00%> (+12.28%) ⬆️
client/daemon/peer/peertask_stream.go 58.11% <0.00%> (+1.13%) ⬆️
client/daemon/peer/peertask_stream_callback.go 65.00% <0.00%> (+2.50%) ⬆️

jim3ma
jim3ma previously approved these changes Jun 9, 2021
scheduler/config/config_darwin.go Outdated Show resolved Hide resolved
scheduler/config/config_linux.go Outdated Show resolved Hide resolved
scheduler/config/config_test.go Outdated Show resolved Hide resolved
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 6db732e into main Jun 9, 2021
@gaius-qi gaius-qi deleted the feature/dynamic-config branch June 9, 2021 08:30
gaius-qi added a commit that referenced this pull request Jun 28, 2023
…304)

* feat: add dynconfig get cdn infos from directory

Signed-off-by: Gaius <[email protected]>

* fix: use dynconfig.LocalSourceType

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
…ss#304)

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants