-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynconfig in schduler gets the cdn configuration from the directory #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 43.53% 43.81% +0.27%
==========================================
Files 53 53
Lines 4176 4195 +19
==========================================
+ Hits 1818 1838 +20
+ Misses 2120 2119 -1
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jim3ma
previously approved these changes
Jun 9, 2021
Signed-off-by: Gaius <[email protected]>
jim3ma
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
244372610
approved these changes
Jun 9, 2021
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
…304) * feat: add dynconfig get cdn infos from directory Signed-off-by: Gaius <[email protected]> * fix: use dynconfig.LocalSourceType Signed-off-by: Gaius <[email protected]>
e-ngo
pushed a commit
to e-ngo/dragonfly
that referenced
this pull request
Jan 23, 2025
…ss#304) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v1...v2) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaius [email protected]
Description
getCDNFromDir
in schduler's dynconfig.Dynconfig.CDNDirPath
in schduler's config.Related Issue
#303
Motivation and Context
Scheduler does not need to rely on manager service.
Screenshots (if appropriate):
Types of changes
Checklist: