Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add context timeout to health check #2943

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: add context timeout to health check #2943

merged 2 commits into from
Dec 15, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Fixes #2930

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the bug label Dec 15, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 15, 2023
@gaius-qi gaius-qi self-assigned this Dec 15, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 15, 2023 03:41
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #2943 (0165fdf) into main (839e476) will not change coverage.
The diff coverage is n/a.

❗ Current head 0165fdf differs from pull request most recent head 89323da. Consider uploading reports for the commit 89323da to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2943   +/-   ##
=======================================
  Coverage   51.08%   51.08%           
=======================================
  Files         161      161           
  Lines       21831    21831           
=======================================
  Hits        11152    11152           
  Misses      10019    10019           
  Partials      660      660           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gaius-qi gaius-qi requested a review from a team as a code owner December 15, 2023 04:02
@gaius-qi gaius-qi merged commit e7c8703 into main Dec 15, 2023
18 checks passed
@gaius-qi gaius-qi deleted the fix/healcheck branch December 15, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preheat failure
2 participants