Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid hot resolve in grpc #2884

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat: avoid hot resolve in grpc #2884

merged 1 commit into from
Nov 15, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 15, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 15, 2023
@gaius-qi gaius-qi self-assigned this Nov 15, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 15, 2023 13:56
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #2884 (4a48421) into main (4d4ea8d) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 40.74%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
- Coverage   50.98%   50.95%   -0.04%     
==========================================
  Files         161      161              
  Lines       21760    21779      +19     
==========================================
+ Hits        11094    11097       +3     
- Misses      10005    10018      +13     
- Partials      661      664       +3     
Flag Coverage Δ
e2etests ?
unittests 50.95% <40.74%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/config/config.go 89.13% <100.00%> (+0.15%) ⬆️
scheduler/service/service_v1.go 79.68% <100.00%> (ø)
internal/dynconfig/dynconfig.go 70.00% <42.85%> (+3.33%) ⬆️
client/config/dynconfig_manager.go 54.95% <14.28%> (-1.46%) ⬇️
scheduler/config/dynconfig.go 21.49% <14.28%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 9608eff into main Nov 15, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/resolver branch November 15, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant