Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preheat with multi arch image layers #2864

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 8, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 8, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 8, 2023
@gaius-qi gaius-qi self-assigned this Nov 8, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 8, 2023 07:15
@gaius-qi gaius-qi changed the title refactor: preheat with image auth client refactor: preheat with multi arch image layers Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2864 (7d4ec96) into main (39a15e1) will increase coverage by 0.09%.
The diff coverage is 85.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
+ Coverage   51.53%   51.63%   +0.09%     
==========================================
  Files         162      161       -1     
  Lines       21851    21809      -42     
==========================================
  Hits        11262    11262              
+ Misses       9922     9885      -37     
+ Partials      667      662       -5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.63% <85.98%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
manager/job/types.go 80.00% <84.61%> (+49.23%) ⬆️
manager/job/preheat.go 54.74% <86.17%> (+11.58%) ⬆️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 2339e9b into main Nov 8, 2023
@gaius-qi gaius-qi deleted the feature/preheat branch November 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants