Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use go-version-file: go.mod for go version detecting #2694

Merged

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Sep 3, 2023

Description

use go-version-file: go.mod for go version detecting

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@yxxhero yxxhero requested a review from a team as a code owner September 3, 2023 15:13
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #2694 (a0387b8) into main (e177ac5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
- Coverage   52.07%   52.05%   -0.03%     
==========================================
  Files         157      157              
  Lines       21196    21196              
==========================================
- Hits        11038    11033       -5     
- Misses       9517     9523       +6     
+ Partials      641      640       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 52.05% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@yxxhero
Copy link
Member Author

yxxhero commented Sep 3, 2023

it's cool for version detection.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit db4dcaf into dragonflyoss:main Sep 5, 2023
@yxxhero yxxhero deleted the feat-use-go-version-file--go.mod branch September 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants