Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initialize object storage client in the New func #2682

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request client labels Aug 29, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Aug 29, 2023
@gaius-qi gaius-qi self-assigned this Aug 29, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner August 29, 2023 06:15
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2682 (19df275) into main (c0522c1) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
- Coverage   51.89%   51.88%   -0.01%     
==========================================
  Files         157      157              
  Lines       21165    21165              
==========================================
- Hits        10983    10981       -2     
  Misses       9543     9543              
- Partials      639      641       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.88% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 85b4467 into main Aug 29, 2023
@gaius-qi gaius-qi deleted the feature/object-storage branch August 29, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants