Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: peer information is changed from being stored in metrics to being stored in mysql #2654

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 21, 2023

Description

  1. Add peer table in mysql in manager.
  2. Add peer query api in manager.
  3. Remove peer total metrics in manager.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Aug 21, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Aug 21, 2023
@gaius-qi gaius-qi self-assigned this Aug 21, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner August 21, 2023 10:02
@gaius-qi gaius-qi requested review from imeoer, yxxhero and eryugey August 21, 2023 10:02
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2654 (e778f3f) into main (bf6e08b) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   51.67%   51.73%   +0.05%     
==========================================
  Files         158      157       -1     
  Lines       21117    21088      -29     
==========================================
- Hits        10913    10910       -3     
+ Misses       9572     9547      -25     
+ Partials      632      631       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.73% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
manager/metrics/metrics.go 100.00% <ø> (ø)
manager/rpcserver/manager_server_v1.go 0.00% <ø> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <ø> (ø)
manager/rpcserver/rpcserver.go 0.00% <0.00%> (ø)
manager/config/config.go 96.41% <100.00%> (-0.02%) ⬇️

... and 4 files with indirect coverage changes

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit c04462e into main Aug 22, 2023
@gaius-qi gaius-qi deleted the feature/peer branch August 22, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants