Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in the objectstorage based on JuiceFS use cases. #2648

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

XDTD
Copy link
Contributor

@XDTD XDTD commented Aug 17, 2023

Description

"Fixing issues in the object storage based on JuiceFS use cases. Mainly includes:

  1. Route path of createbucket.
  2. Unable to properly pass objectkey when calling copyobject.
  3. Oss GetObjectMeta return not found error.
  4. getObjectMetadatas does not include directories.

Related Issue

#2176

Motivation and Context

To provide support for JuiceFS objectStorage implementation.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@XDTD XDTD requested a review from a team as a code owner August 17, 2023 08:42
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2648 (a2523c5) into main (85b4467) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
+ Coverage   51.87%   51.97%   +0.10%     
==========================================
  Files         157      157              
  Lines       21165    21165              
==========================================
+ Hits        10979    11001      +22     
+ Misses       9545     9523      -22     
  Partials      641      641              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.97% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

client/daemon/objectstorage/objectstorage.go Outdated Show resolved Hide resolved
pkg/objectstorage/oss.go Outdated Show resolved Hide resolved
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add default httpclient.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c29edd2 into dragonflyoss:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants