Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace fmt.Sprintf with net.JoinHostPort #2642

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: replace fmt.Sprintf with net.JoinHostPort #2642

merged 1 commit into from
Aug 16, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Aug 16, 2023
@gaius-qi gaius-qi added this to the v2.1.1 milestone Aug 16, 2023
@gaius-qi gaius-qi self-assigned this Aug 16, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner August 16, 2023 08:33
@gaius-qi gaius-qi merged commit a6863f9 into main Aug 16, 2023
@gaius-qi gaius-qi deleted the feature/join branch August 16, 2023 08:45
gaius-qi added a commit that referenced this pull request Aug 17, 2023
@gaius-qi
Revert "feat: replace fmt.Sprintf with net.JoinHostPort (#2642)"
f572e4b 
This reverts commit a6863f9.
@gaius-qi gaius-qi mentioned this pull request Aug 17, 2023
Merged
gaius-qi added a commit that referenced this pull request Aug 17, 2023
@gaius-qi
Revert "feat: replace fmt.Sprintf with net.JoinHostPort" (#2649)
5b7ea5d 
Revert "feat: replace fmt.Sprintf with net.JoinHostPort (#2642)"

This reverts commit a6863f9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@allencloud allencloud Awaiting requested review from allencloud allencloud is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@eryugey eryugey Awaiting requested review from eryugey eryugey is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gaius-qi @yxxhero