Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check task id #2636

Merged
merged 1 commit into from
Aug 15, 2023
Merged

chore: check task id #2636

merged 1 commit into from
Aug 15, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 15, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <[email protected]>
@jim3ma jim3ma requested a review from a team as a code owner August 15, 2023 09:40
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2636 (ae073c4) into main (25d12b2) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2636      +/-   ##
==========================================
- Coverage   51.53%   51.48%   -0.05%     
==========================================
  Files         158      158              
  Lines       21103    21109       +6     
==========================================
- Hits        10875    10869       -6     
- Misses       9601     9608       +7     
- Partials      627      632       +5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.48% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
scheduler/resource/peer.go 71.95% <0.00%> (-1.11%) ⬇️
client/daemon/peer/piece_downloader.go 52.94% <33.33%> (-3.76%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 0e04a56 into main Aug 15, 2023
@gaius-qi gaius-qi deleted the chore/check-task-id branch August 15, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants