Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add traffic #2634

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: add traffic #2634

merged 2 commits into from
Aug 15, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 15, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner August 15, 2023 09:22
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2634 (2a79e23) into main (bd140f1) will increase coverage by 0.06%.
Report is 20 commits behind head on main.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   51.49%   51.56%   +0.06%     
==========================================
  Files         158      158              
  Lines       21049    21102      +53     
==========================================
+ Hits        10840    10882      +42     
- Misses       9581     9594      +13     
+ Partials      628      626       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.56% <66.66%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/daemon/peer/piece_manager.go 53.05% <66.66%> (+0.33%) ⬆️

... and 14 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 554b27c into main Aug 15, 2023
@gaius-qi gaius-qi deleted the fix/add-traffic branch August 15, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants