Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: net.JoinHostPort replace fmt.Sprintf #2622

Merged
merged 1 commit into from
Aug 11, 2023
Merged

feat: net.JoinHostPort replace fmt.Sprintf #2622

merged 1 commit into from
Aug 11, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Aug 11, 2023
@gaius-qi gaius-qi added this to the v2.1.1 milestone Aug 11, 2023
@gaius-qi gaius-qi self-assigned this Aug 11, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner August 11, 2023 02:40
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2622 (3eef5fd) into main (a5b0f74) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2622      +/-   ##
==========================================
- Coverage   51.53%   51.51%   -0.02%     
==========================================
  Files         158      158              
  Lines       21100    21100              
==========================================
- Hits        10873    10869       -4     
- Misses       9600     9602       +2     
- Partials      627      629       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.51% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/config/dfstore.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 9e1bb52 into main Aug 11, 2023
@gaius-qi gaius-qi deleted the feature/port branch August 11, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants