Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manager generates mTLS certificates for arbitrary IP addresses #2615

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 9, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Aug 9, 2023
@gaius-qi gaius-qi added this to the v2.1.1 milestone Aug 9, 2023
@gaius-qi gaius-qi self-assigned this Aug 9, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner August 9, 2023 07:33
@gaius-qi gaius-qi requested review from imeoer, yxxhero and eryugey August 9, 2023 07:33
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2615 (750b57f) into main (77c91cb) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
- Coverage   51.45%   51.45%   -0.01%     
==========================================
  Files         158      158              
  Lines       21085    21069      -16     
==========================================
- Hits        10850    10841       -9     
+ Misses       9605     9601       -4     
+ Partials      630      627       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.45% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
manager/rpcserver/security_server_v1.go 61.70% <40.00%> (-1.79%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit d9e8b28 into main Aug 9, 2023
@gaius-qi gaius-qi deleted the feature/cert branch August 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants