Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add personal access token middleware to open api #2590

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 1, 2023

Description

Related Issue

#2582

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Aug 1, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Aug 1, 2023
@gaius-qi gaius-qi self-assigned this Aug 1, 2023
yxxhero
yxxhero previously approved these changes Aug 1, 2023
@gaius-qi gaius-qi force-pushed the feature/personal-access-token branch from e4ba923 to 1639e8a Compare August 1, 2023 06:09
@gaius-qi gaius-qi requested a review from a team as a code owner August 1, 2023 06:09
hyy0322
hyy0322 previously approved these changes Aug 1, 2023
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2590 (2e85c62) into main (d894aff) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   51.62%   51.62%   -0.01%     
==========================================
  Files         158      158              
  Lines       21006    21006              
==========================================
- Hits        10845    10844       -1     
+ Misses       9542     9540       -2     
- Partials      619      622       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@gaius-qi gaius-qi force-pushed the feature/personal-access-token branch from 1639e8a to 2e85c62 Compare August 1, 2023 06:49
@gaius-qi gaius-qi merged commit b723181 into main Aug 1, 2023
@gaius-qi gaius-qi deleted the feature/personal-access-token branch August 1, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants