Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add finished piece count element in types #2557

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented Jul 18, 2023

Add finished piece count element in types.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@fcgxz2003 fcgxz2003 requested a review from a team as a code owner July 18, 2023 13:21
@fcgxz2003 fcgxz2003 self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #2557 (0aec09b) into main (94e4b7a) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
+ Coverage   51.51%   51.53%   +0.02%     
==========================================
  Files         158      158              
  Lines       20988    20990       +2     
==========================================
+ Hits        10811    10818       +7     
+ Misses       9556     9554       -2     
+ Partials      621      618       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.53% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/service/service_v1.go 80.33% <50.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

scheduler/storage/types.go Outdated Show resolved Hide resolved
scheduler/storage/types.go Outdated Show resolved Hide resolved
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit be6d808 into dragonflyoss:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants