Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduler test #252

Merged
merged 2 commits into from
May 24, 2021
Merged

Fix scheduler test #252

merged 2 commits into from
May 24, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

Fix scheduler test.

Related Issue

#251

Motivation and Context

N/A

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi
test: create cache
95e6eb8 
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi self-assigned this May 24, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner May 24, 2021 09:46
@gaius-qi gaius-qi requested review from jim3ma, ansinlee and 244372610 May 24, 2021 09:46
@gaius-qi
feat: error check
c968d40 
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi linked an issue May 24, 2021 that may be closed by this pull request
Fix scheduler test #251
Closed
jim3ma
jim3ma approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit b600800 into main May 24, 2021
@gaius-qi gaius-qi deleted the feature/scheduler branch May 24, 2021 11:51
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
Fix scheduler test (#252)
7ccd6af 
* test: create cache

Signed-off-by: Gaius <[email protected]>

* feat: error check

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
fix: caculate range length of range header (dragonflyoss#252)
f6f944d 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@yangjun289519474 yangjun289519474 yangjun289519474 approved these changes

@ansinlee ansinlee Awaiting requested review from ansinlee

@244372610 244372610 Awaiting requested review from 244372610

Assignees

@gaius-qi gaius-qi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix scheduler test
3 participants
@gaius-qi @jim3ma @yangjun289519474