Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manager orm store #248

Merged
merged 5 commits into from
May 24, 2021
Merged

Conversation

yangjun289519474
Copy link
Contributor

refacor manager orm store, be more convenient to add new features

split orm_stroe.go to several files by diffrents entries

#247

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yangjun289519474 yangjun289519474 requested a review from a team as a code owner May 24, 2021 02:32
@yangjun289519474 yangjun289519474 self-assigned this May 24, 2021
@yangjun289519474 yangjun289519474 changed the title refactor: manager orm store Refactor: manager orm store May 24, 2021
@yangjun289519474 yangjun289519474 requested a review from gaius-qi May 24, 2021 02:43
manager/config/config.go Outdated Show resolved Hide resolved
manager/store/orm/orm_store.go Outdated Show resolved Hide resolved
gaius-qi
gaius-qi previously approved these changes May 24, 2021
244372610
244372610 previously approved these changes May 24, 2021
@yangjun289519474 yangjun289519474 requested review from jim3ma and removed request for jim3ma and ansinlee May 24, 2021 07:27
manager/config/config.go Outdated Show resolved Hide resolved
manager/config/config.go Outdated Show resolved Hide resolved
manager/config/config.go Outdated Show resolved Hide resolved
@yangjun289519474 yangjun289519474 dismissed stale reviews from 244372610 and gaius-qi via 977a45d May 24, 2021 08:12
@yangjun289519474 yangjun289519474 requested a review from jim3ma May 24, 2021 08:14
jim3ma
jim3ma previously approved these changes May 24, 2021
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

244372610
244372610 previously approved these changes May 24, 2021
@yangjun289519474 yangjun289519474 dismissed stale reviews from 244372610 and jim3ma via b4ad6fe May 24, 2021 09:25
@yangjun289519474 yangjun289519474 force-pushed the refactor/manager-orm-store branch 2 times, most recently from b4ad6fe to a0988dd Compare May 24, 2021 09:37
@yangjun289519474 yangjun289519474 requested a review from a team as a code owner May 24, 2021 09:37
yangjun289519474 and others added 5 commits May 24, 2021 17:39
* feature: add basic auth support for proxy

Signed-off-by: Jim Ma <[email protected]>Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: Gaius <[email protected]>Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>
@yangjun289519474 yangjun289519474 force-pushed the refactor/manager-orm-store branch from a0988dd to 019b3dc Compare May 24, 2021 09:39
@gaius-qi gaius-qi changed the title Refactor: manager orm store Refactor manager orm store May 24, 2021
@yangjun289519474 yangjun289519474 merged commit 9fbaf84 into main May 24, 2021
@yangjun289519474 yangjun289519474 deleted the refactor/manager-orm-store branch May 24, 2021 10:25
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* refactor: manager orm store

Signed-off-by: hanson.yj <[email protected]>

* refactor: manager orm store

Signed-off-by: hanson.yj <[email protected]>

* refactor: manager orm store

Signed-off-by: hanson.yj <[email protected]>

* Feature: support basic auth for proxy (#250)

* feature: add basic auth support for proxy

Signed-off-by: Jim Ma <[email protected]>Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>

* Fix golang lint (#249)

Signed-off-by: Gaius <[email protected]>Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>

Co-authored-by: hanson.yj <[email protected]>
Co-authored-by: Jim Ma <[email protected]>
Co-authored-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants