-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor manager orm store #248
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaius-qi
requested changes
May 24, 2021
gaius-qi
previously approved these changes
May 24, 2021
244372610
previously approved these changes
May 24, 2021
jim3ma
reviewed
May 24, 2021
jim3ma
previously approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
244372610
previously approved these changes
May 24, 2021
b4ad6fe
to
a0988dd
Compare
Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: hanson.yj <[email protected]>
* feature: add basic auth support for proxy Signed-off-by: Jim Ma <[email protected]>Signed-off-by: hanson.yj <[email protected]> Signed-off-by: hanson.yj <[email protected]>
Signed-off-by: Gaius <[email protected]>Signed-off-by: hanson.yj <[email protected]> Signed-off-by: hanson.yj <[email protected]>
a0988dd
to
019b3dc
Compare
gaius-qi
approved these changes
May 24, 2021
244372610
approved these changes
May 24, 2021
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
* refactor: manager orm store Signed-off-by: hanson.yj <[email protected]> * refactor: manager orm store Signed-off-by: hanson.yj <[email protected]> * refactor: manager orm store Signed-off-by: hanson.yj <[email protected]> * Feature: support basic auth for proxy (#250) * feature: add basic auth support for proxy Signed-off-by: Jim Ma <[email protected]>Signed-off-by: hanson.yj <[email protected]> Signed-off-by: hanson.yj <[email protected]> * Fix golang lint (#249) Signed-off-by: Gaius <[email protected]>Signed-off-by: hanson.yj <[email protected]> Signed-off-by: hanson.yj <[email protected]> Co-authored-by: hanson.yj <[email protected]> Co-authored-by: Jim Ma <[email protected]> Co-authored-by: Gaius <[email protected]>
e-ngo
pushed a commit
to e-ngo/dragonfly
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refacor manager orm store, be more convenient to add new features
split orm_stroe.go to several files by diffrents entries
#247
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: