Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e test dfget recursive #2458

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix: e2e test dfget recursive #2458

merged 2 commits into from
Jun 13, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jun 13, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner June 13, 2023 08:26
@jim3ma jim3ma requested review from imeoer, allencloud and hyy0322 June 13, 2023 08:26
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2458 (cdf974c) into main (afd81b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2458   +/-   ##
=======================================
  Coverage   50.90%   50.90%           
=======================================
  Files         151      151           
  Lines       20058    20058           
=======================================
  Hits        10210    10210           
  Misses       9238     9238           
  Partials      610      610           
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 50.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 0bbd437 into main Jun 13, 2023
@gaius-qi gaius-qi deleted the fix/e2e-test-dfget-recursive branch June 13, 2023 09:21
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants