Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when bufferSize is zero, storage can not write data to file #2366

Merged
merged 2 commits into from
May 22, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • When bufferSize is zero, createDownload and createNetworkTopology can not write data to file, because buffer is empty.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

When bufferSize is zero, createDownload and createNetworkTopology
can not write data to file, because buffer is empty.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added the enhancement New feature or request label May 22, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 22, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 22, 2023 03:02
@gaius-qi gaius-qi self-assigned this May 22, 2023
Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@39c9839). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2366   +/-   ##
=======================================
  Coverage        ?   49.69%           
=======================================
  Files           ?      148           
  Lines           ?    19644           
  Branches        ?        0           
=======================================
  Hits            ?     9762           
  Misses          ?     9268           
  Partials        ?      614           
Flag Coverage Δ
unittests 49.69% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/storage/storage.go 77.59% <100.00%> (ø)

@gaius-qi gaius-qi merged commit 1c5eb86 into main May 22, 2023
@gaius-qi gaius-qi deleted the feature/storage branch May 22, 2023 06:09
gaius-qi added a commit that referenced this pull request Jun 28, 2023
When bufferSize is zero, createDownload and createNetworkTopology
can not write data to file, because buffer is empty.

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants