Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove traffic_type in DownloadPeerDuration metric #2357

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

gaius-qi
Copy link
Member

Description

  • Remove traffic_type in DownloadPeerDuration metric.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label May 16, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 16, 2023
@gaius-qi gaius-qi self-assigned this May 16, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 16, 2023 13:01
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2357 (5334809) into main (acff931) will increase coverage by 49.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #2357       +/-   ##
=========================================
+ Coverage      0   49.68%   +49.68%     
=========================================
  Files         0      148      +148     
  Lines         0    19644    +19644     
=========================================
+ Hits          0     9761     +9761     
- Misses        0     9269     +9269     
- Partials      0      614      +614     
Flag Coverage Δ
unittests 49.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/metrics/metrics.go 100.00% <ø> (ø)
scheduler/service/service_v1.go 79.38% <100.00%> (ø)
scheduler/service/service_v2.go 83.78% <100.00%> (ø)

... and 145 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 4849b0a into main May 16, 2023
@gaius-qi gaius-qi deleted the feature/peer branch May 16, 2023 13:20
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants