feat: add traffic type of peer task download duration #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
+ Coverage 49.71% 49.76% +0.05%
==========================================
Files 148 148
Lines 19640 19644 +4
==========================================
+ Hits 9764 9776 +12
+ Misses 9265 9255 -10
- Partials 611 613 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
requested changes
May 15, 2023
litianxi
force-pushed
the
main
branch
2 times, most recently
from
f98e9c0 to
d579a51
Compare
gaius-qi
requested changes
May 15, 2023
There was a problem hiding this comment.
Fix unit testing.
2023-05-15T07:22:43.5857994Z --- FAIL: TestServiceV2_handleDownloadPeerFinishedRequest (0.00s)
2023-05-15T07:22:43.5858403Z --- PASS: TestServiceV2_handleDownloadPeerFinishedRequest/peer_can_not_be_loaded (0.00s)
2023-05-15T07:22:43.5858899Z --- PASS: TestServiceV2_handleDownloadPeerFinishedRequest/peer_state_is_PeerStateSucceeded (0.00s)
2023-05-15T07:22:43.5859335Z --- FAIL: TestServiceV2_handleDownloadPeerFinishedRequest/peer_state_is_PeerStateRunning (0.00s)
2023-05-15T07:22:43.5859633Z panic: inconsistent label cardinality: expected 6 label values but got 5 in []string{"LEVEL0", "DFDAEMON", "d7y", "foo", "normal"} [recovered]
2023-05-15T07:22:43.5859958Z panic: inconsistent label cardinality: expected 6 label values but got 5 in []string{"LEVEL0", "DFDAEMON", "d7y", "foo", "normal"} [recovered]
2023-05-15T07:22:43.5860256Z panic: inconsistent label cardinality: expected 6 label values but got 5 in []string{"LEVEL0", "DFDAEMON", "d7y", "foo", "normal"}
It failed the service v2's unit test, it seems that if the service v2's logic is not modified, it will be affected |
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Co-authored-by: li.tianxi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add traffic type of peer task download duration