Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change DefaultServerPort to 9090 in trainer #2348

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

gaius-qi
Copy link
Member

Description

  • Change DefaultServerPort to 9090 in trainer.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request trainer labels May 12, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone May 12, 2023
@gaius-qi gaius-qi self-assigned this May 12, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner May 12, 2023 09:37
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2348 (76f7b5f) into main (bb30434) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   49.69%   49.69%   -0.01%     
==========================================
  Files         148      148              
  Lines       19640    19640              
==========================================
- Hits         9761     9760       -1     
- Misses       9267     9268       +1     
  Partials      612      612              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit cd0b95d into main May 12, 2023
@gaius-qi gaius-qi deleted the feature/port branch May 12, 2023 10:02
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request trainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant