Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github docker workflow timeouts while building manager image #2272

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Github docker workflow timeouts while building manager image #2272

merged 3 commits into from
Apr 13, 2023

Conversation

ieuD
Copy link
Contributor

@ieuD ieuD commented Apr 13, 2023

Description

Docker build job breaks due to workflow timeout limit at Line24

crane config ghcr.io/dragonflyoss/dragonfly2/manager:latest@sha256:f896f04f90f8ccacf007f26c7513b3ff6068e96abddf2899982e90af89e6509d | jq
{
  "architecture": "unknown",
  "os": "unknown",
  "config": {},
  "rootfs": {
    "type": "layers",
    "diff_ids": [
      "sha256:53247f5000d7fa895af6d05686da234ab9fad161739489c070b1ca6d2fa0cb37"
    ]
  }
}

Increase timeout limit on the pipeline.

Related Issue

Issue: #2271

Motivation and Context

Arm64 architecture images released except Manager image.

Screenshots (if appropriate)

image

image

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

ieuD and others added 3 commits April 12, 2023 19:12
@ieuD ieuD requested a review from a team as a code owner April 13, 2023 08:29
@ieuD ieuD requested review from garenwen, yxxhero and hyy0322 April 13, 2023 08:29
jim3ma
jim3ma approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaius-qi
gaius-qi approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 0f95de6 into dragonflyoss:main Apr 13, 2023
@ieuD
Copy link
Contributor Author

ieuD commented Apr 13, 2023

@gaius-qi Hi I'm not sure how much does it take but somehow we should play with it

lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
@ieuD
Github docker workflow timeouts while building manager image (dragonf…
2e0caff 
…lyoss#2272)

Signed-off-by: Eren Cankurtaran <[email protected]>
Co-authored-by: Eren Cankurtaran <[email protected]>
Signed-off-by: 李龙峰 <[email protected]>
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@ieuD @gaius-qi
Github docker workflow timeouts while building manager image (#2272)
b676199 
Signed-off-by: Eren Cankurtaran <[email protected]>
Co-authored-by: Eren Cankurtaran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@gaius-qi gaius-qi gaius-qi approved these changes

@garenwen garenwen Awaiting requested review from garenwen garenwen is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

@yxxhero yxxhero Awaiting requested review from yxxhero yxxhero is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

@hyy0322 hyy0322 Awaiting requested review from hyy0322 hyy0322 is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ieuD @jim3ma @gaius-qi