Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local dynconfig panic in Notify #2266

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix: local dynconfig panic in Notify #2266

merged 1 commit into from
Apr 12, 2023

Conversation

gaius-qi
Copy link
Member

Fix local dynconfig panic in Notify and
add scheduler addr test in config.

Description

  • Fix local dynconfig panic in Notify.
  • Add scheduler addr test in config.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request client labels Apr 12, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Apr 12, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner April 12, 2023 08:27
@gaius-qi gaius-qi self-assigned this Apr 12, 2023
hyy0322
hyy0322 previously approved these changes Apr 12, 2023
Fix local dynconfig panic in Notify and
add scheduler addr test in config.

Signed-off-by: Gaius <[email protected]>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #2266 (5548a7f) into main (f2e42bc) will decrease coverage by 0.09%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   49.67%   49.59%   -0.09%     
==========================================
  Files         146      146              
  Lines       19526    19520       -6     
==========================================
- Hits         9700     9680      -20     
- Misses       9229     9242      +13     
- Partials      597      598       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.59% <80.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dynconfig_local.go 38.63% <0.00%> (ø)
client/config/peerhost_linux.go 100.00% <ø> (ø)
client/config/peerhost.go 44.35% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit 0216655 into main Apr 12, 2023
@gaius-qi gaius-qi deleted the feature/scheduler-addr branch April 12, 2023 08:52
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
Fix local dynconfig panic in Notify and
add scheduler addr test in config.

Signed-off-by: Gaius <[email protected]>
Signed-off-by: 李龙峰 <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Fix local dynconfig panic in Notify and
add scheduler addr test in config.

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants