feat: local dynconfig notifies data in client #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyy0322
previously approved these changes
Apr 12, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #2264 +/- ##
==========================================
- Coverage 49.61% 49.60% -0.02%
==========================================
Files 146 146
Lines 19513 19526 +13
==========================================
+ Hits 9682 9685 +3
- Misses 9233 9245 +12
+ Partials 598 596 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Dfdaemon will fail the health check if there is no available scheduler address. So in the case of local dynconfig, the address of scheduler should be passed. For dfdaemon health check, please refer to #2130. Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/dynconfig
branch
from
4d9e2fa to
4ca5f1f
Compare
lilongfeng0902
pushed a commit
to lilongfeng0902/Dragonfly2
that referenced
this pull request
May 15, 2023
Dfdaemon will fail the health check if there is no available scheduler address. So in the case of local dynconfig, the address of scheduler should be passed. For dfdaemon health check, please refer to dragonflyoss#2130. Signed-off-by: Gaius <[email protected]> Signed-off-by: 李龙峰 <[email protected]>
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
Dfdaemon will fail the health check if there is no available scheduler address. So in the case of local dynconfig, the address of scheduler should be passed. For dfdaemon health check, please refer to #2130. Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dfdaemon will fail the health check if there is no available scheduler address. So in the case of local dynconfig, the address of scheduler should be passed. For dfdaemon health check, please refer to #2130.
Description
Dfdaemon will fail the health check if there is no available scheduler address. So in the case of local dynconfig, the address of scheduler should be passed. For dfdaemon health check, please refer to #2130.
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist