Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logger.CoreLogger to searcher plugin #2232

Merged
merged 1 commit into from
Mar 30, 2023
Merged

feat: add logger.CoreLogger to searcher plugin #2232

merged 1 commit into from
Mar 30, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Add logger.CoreLogger to searcher plugin.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Mar 30, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 30, 2023
@gaius-qi gaius-qi self-assigned this Mar 30, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 30, 2023 09:35
hyy0322
hyy0322 approved these changes Mar 30, 2023
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 3fbeac2 into main Mar 30, 2023
@gaius-qi gaius-qi deleted the feature/searcher-log branch March 30, 2023 09:45
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 31, 2023
@gaius-qi @MIchaelFU0403
feat: add logger.CoreLogger to searcher plugin (dragonflyoss#2232)
019cb57 
Signed-off-by: Gaius <[email protected]>
Signed-off-by: MIchaelFU0403 <[email protected]>
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
@gaius-qi
feat: add logger.CoreLogger to searcher plugin (dragonflyoss#2232)
2743a04 
Signed-off-by: Gaius <[email protected]>
Signed-off-by: 李龙峰 <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
feat: add logger.CoreLogger to searcher plugin (#2232)
acb8f70 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@hyy0322 hyy0322 hyy0322 approved these changes

@imeoer imeoer Awaiting requested review from imeoer imeoer is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@hhhhsdxxxx hhhhsdxxxx Awaiting requested review from hhhhsdxxxx hhhhsdxxxx is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
enhancement New feature or request manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaius-qi @yxxhero @hyy0322