Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log to searcher plugin #2231

Merged
merged 1 commit into from
Mar 30, 2023
Merged

feat: add log to searcher plugin #2231

merged 1 commit into from
Mar 30, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Add log to searcher plugin.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Mar 30, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 30, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 30, 2023 07:57
@gaius-qi gaius-qi self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #2231 (ff6a07d) into main (b9a6c7d) will decrease coverage by 0.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
- Coverage   49.69%   49.68%   -0.01%     
==========================================
  Files         145      145              
  Lines       19317    19318       +1     
==========================================
- Hits         9600     9599       -1     
- Misses       9126     9127       +1     
- Partials      591      592       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.68% <41.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)
manager/searcher/searcher.go 81.45% <50.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 0d4ff92 into main Mar 30, 2023
@gaius-qi gaius-qi deleted the feature/searcher branch March 30, 2023 08:23
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 31, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants