Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trainer service to rpc package #2209

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat: add trainer service to rpc package #2209

merged 1 commit into from
Mar 22, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Add trainer service to rpc package

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Mar 22, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 22, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 22, 2023 12:11
@gaius-qi gaius-qi self-assigned this Mar 22, 2023
@gaius-qi gaius-qi force-pushed the feature/trainer branch 2 times, most recently from 99c0d21 to aac54f5 Compare March 22, 2023 12:15
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #2209 (6e5bb40) into main (cd94e99) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
+ Coverage   49.44%   49.47%   +0.02%     
==========================================
  Files         141      141              
  Lines       19200    19200              
==========================================
+ Hits         9494     9499       +5     
+ Misses       9117     9114       -3     
+ Partials      589      587       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.47% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 95b462a into main Mar 22, 2023
@gaius-qi gaius-qi deleted the feature/trainer branch March 22, 2023 12:31
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants