Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics to service v2 #2153

Merged
merged 1 commit into from
Mar 10, 2023
Merged

feat: add metrics to service v2 #2153

merged 1 commit into from
Mar 10, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • Add metrics to service v2.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Mar 10, 2023
@gaius-qi gaius-qi added this to the v2.0.9 milestone Mar 10, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 10, 2023 07:04
@gaius-qi gaius-qi self-assigned this Mar 10, 2023
hyy0322
hyy0322 previously approved these changes Mar 10, 2023
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #2153 (01736e5) into main (cddcac7) will increase coverage by 0.08%.
The diff coverage is 58.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
+ Coverage   47.84%   47.93%   +0.08%     
==========================================
  Files         141      141              
  Lines       19493    19640     +147     
==========================================
+ Hits         9327     9415      +88     
- Misses       9577     9634      +57     
- Partials      589      591       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 47.93% <58.98%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)
scheduler/resource/seed_peer.go 20.86% <0.00%> (-0.16%) ⬇️
scheduler/rpcserver/scheduler_server_v1.go 2.46% <0.00%> (-0.87%) ⬇️
scheduler/rpcserver/scheduler_server_v2.go 2.56% <0.00%> (-0.77%) ⬇️
scheduler/service/service_v1.go 79.36% <71.42%> (-0.15%) ⬇️
scheduler/service/service_v2.go 83.63% <84.11%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 5d5804e into main Mar 10, 2023
@gaius-qi gaius-qi deleted the feature/metrics branch March 10, 2023 08:27
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 21, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants