Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement v2 version of scheduler service #2125

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 28, 2023

Description

  • Implement StatTask, AnnounceHost and LeaveHost api in scheduler service v2.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Implement StatTask, AnnounceHost and LeaveHost api in
scheduler service v2.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Feb 28, 2023
@gaius-qi gaius-qi added this to the v2.0.9 milestone Feb 28, 2023
@gaius-qi gaius-qi self-assigned this Feb 28, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner February 28, 2023 06:58
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #2125 (c0a11ef) into main (de2a7c9) will increase coverage by 2.45%.
The diff coverage is 81.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2125      +/-   ##
==========================================
+ Coverage   42.28%   44.74%   +2.45%     
==========================================
  Files         141      141              
  Lines       18666    18907     +241     
==========================================
+ Hits         7893     8459     +566     
+ Misses      10198     9873     -325     
  Partials      575      575              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 44.74% <81.09%> (+2.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/piece_manager_mock.go 0.00% <0.00%> (ø)
scheduler/resource/seed_peer_mock.go 0.00% <0.00%> (ø)
scheduler/rpcserver/scheduler_server_v1.go 3.33% <0.00%> (-0.06%) ⬇️
scheduler/rpcserver/scheduler_server_v2.go 3.63% <0.00%> (-2.82%) ⬇️
client/daemon/peer/peertask_manager_mock.go 36.81% <25.00%> (ø)
scheduler/service/service_v2.go 96.04% <98.19%> (+5.57%) ⬆️
scheduler/service/service_v1.go 79.52% <100.00%> (+14.40%) ⬆️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 52.55% <0.00%> (-3.61%) ⬇️
client/config/peerhost.go 44.10% <0.00%> (+11.02%) ⬆️
... and 2 more

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit dbbf329 into main Feb 28, 2023
@gaius-qi gaius-qi deleted the feature/announce branch February 28, 2023 07:48
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 21, 2023
Implement StatTask, AnnounceHost and LeaveHost api in
scheduler service v2.

Signed-off-by: Gaius <[email protected]>
Signed-off-by: MIchaelFU0403 <[email protected]>
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
Implement StatTask, AnnounceHost and LeaveHost api in
scheduler service v2.

Signed-off-by: Gaius <[email protected]>
Signed-off-by: 李龙峰 <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Implement StatTask, AnnounceHost and LeaveHost api in
scheduler service v2.

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants