Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy transport test #207

Merged
merged 6 commits into from
May 10, 2021
Merged

Proxy transport test #207

merged 6 commits into from
May 10, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented May 8, 2021

Description

  • Fix assert.EqualValues is useless for CertPool
  • Add CertPool custom Unmarshal
  • Refactor transport

Related Issue

#206

Motivation and Context

N/A

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested a review from a team as a code owner May 8, 2021 10:29
@gaius-qi gaius-qi self-assigned this May 8, 2021
@gaius-qi gaius-qi requested review from jim3ma, ansinlee and 244372610 May 8, 2021 10:29
@gaius-qi gaius-qi changed the title Fix CertPool test Fix config test May 8, 2021
@gaius-qi gaius-qi linked an issue May 8, 2021 that may be closed by this pull request
Fix assert.EqualValues is useless for CertPool #206
Closed
@gaius-qi gaius-qi merged commit 1f1b988 into main May 10, 2021
@gaius-qi gaius-qi deleted the feature/client-config branch May 10, 2021 02:26
@gaius-qi gaius-qi changed the title Fix config test Proxy transport test May 28, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
Fix config test (#207)
52cdfaa 
* feat: convert header and meta.Header

Signed-off-by: Gaius <[email protected]>

* fix: assert.EqualValues is useless for CertPool

Signed-off-by: Gaius <[email protected]>

* feat: transport

Signed-off-by: Gaius <[email protected]>

* feat: add pickHeader

Signed-off-by: Gaius <[email protected]>

* test: transport

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
@gaius-qi
feat: report candidate parents when download failed (dragonflyoss#207)
a4f09fb 
Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@yangjun289519474 yangjun289519474 yangjun289519474 approved these changes

@ansinlee ansinlee Awaiting requested review from ansinlee

@244372610 244372610 Awaiting requested review from 244372610

Assignees

@gaius-qi gaius-qi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix assert.EqualValues is useless for CertPool
3 participants
@gaius-qi @jim3ma @yangjun289519474