Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add username when create redis client #1862

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

walleliu1016
Copy link
Contributor

@walleliu1016 walleliu1016 commented Nov 23, 2022

Description

Related Issue

Fix #1861

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@walleliu1016 walleliu1016 requested a review from a team as a code owner November 23, 2022 08:22
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1862 (120f968) into main (c0abbf1) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   42.87%   43.05%   +0.18%     
==========================================
  Files         131      131              
  Lines       16601    16601              
==========================================
+ Hits         7117     7147      +30     
+ Misses       8944     8913      -31     
- Partials      540      541       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.05% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 57.33% <0.00%> (+0.29%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 48.63% <0.00%> (+14.20%) ⬆️

@gaius-qi gaius-qi merged commit 2bf4d5e into dragonflyoss:main Nov 23, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler can not create redis client, if redis server enable acl
4 participants