Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS #160

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Add CODEOWNERS #160

merged 2 commits into from
Apr 27, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 27, 2021 •
edited
Loading

Description

  • Add .github/CODEOWNERS file.
  • Setting the code owner function management authority involves two teams @dragonflyoss/dragonfly-maintainers and @dragonflyoss/dragonfly-reviewer.

Related Issue

#159

Motivation and Context

Use a CODEOWNERS file to define individuals or teams that are responsible for code in a repository.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi requested review from jim3ma and garfield009 April 27, 2021 03:20
@gaius-qi gaius-qi self-assigned this Apr 27, 2021
@gaius-qi gaius-qi force-pushed the feature/codeowners branch from 37bd44b to e7a928a Compare April 27, 2021 03:21
@gaius-qi gaius-qi linked an issue Apr 27, 2021 that may be closed by this pull request
Add CODEOWNERS #159
Closed
@gaius-qi gaius-qi force-pushed the feature/codeowners branch from 13437d3 to c77f838 Compare April 27, 2021 03:35
jim3ma
jim3ma approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 246b43e into main Apr 27, 2021
@jim3ma jim3ma deleted the feature/codeowners branch April 27, 2021 05:58
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
Add CODEOWNERS (#160)
dc4f2f6 
* chore: add CODEOWNERS

Signed-off-by: Gaius <[email protected]>
MinH-09 pushed a commit to MinH-09/Dragonfly2 that referenced this pull request Jul 18, 2023
@gaius-qi
feat: update PrometheusRule in schduler by v2 protocol of metrics (dr…
cf754b3 
…agonflyoss#160)

feat: Update PrometheusRule in schduler by v2 protocol of metrics

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@garfield009 garfield009 garfield009 approved these changes

Assignees

@gaius-qi gaius-qi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CODEOWNERS
3 participants
@gaius-qi @jim3ma @garfield009